Issue 763: Inconsistency in an error message

Reported by Jean-Philippe Fleury, Nov 22, 2011

If we try to register with an already used e-mail, we'll have the 
following error:

"The email "%s" is already used. If you need to, 
click on the help link to recover your password."

See here:

http://projects.ceondo.com/p/indefero/source/tree/develop/src/IDF/For
m/Register.php#L97

The problem is the following: the help link doesn't provide any 
clue/faq to recover our password.

Comment 1 by Jean-Philippe Fleury, Nov 22, 2011

Here's a suggestion (replace actual line 97 with the following):

            throw new Pluf_Form_Invalid(sprintf(__('The email 
"%1$s" is already used. If you need to, you can <a 
href="%2$s">recover your password</a>.'), 
$this->cleaned_data['email'], 
Pluf_HTTP_URL_urlForView('IDF_Views::passwordRecoveryAsk')));

Comment 2 by Jean-Philippe Fleury, Nov 22, 2011

Same problem occurs when we try to confirm an already active 
account:

"This account has already been confirmed. Maybe should you try 
to recover your password using the help link."

See here:

http://projects.ceondo.com/p/indefero/source/tree/develop/src/IDF/For
m/RegisterConfirmation.php#L110

Here's a suggestion (replace actual line 110 with the following):

            throw new Pluf_Form_Invalid(sprintf(__('This account has 
already been confirmed. Maybe should you try to <a 
href="%s">recover your password</a>.'), 
Pluf_HTTP_URL_urlForView('IDF_Views::passwordRecoveryAsk')));

Comment 3 by Thomas Keller, Nov 29, 2011

Could you please provide a patch for both issues? Than I could 
quickly apply and test this. Thanks!

Status: Accepted
Owner: tommyd

Comment 4 by Jean-Philippe Fleury, Nov 29, 2011

Voilà.

0001-Fixes-issue-763.patch - 2.15 kB - view

Comment 5 by Thomas Keller, Nov 30, 2011

Tested and applied in revision 154597c. Thanks again!

Labels: Milestone:Release1.2.1

Comment 6 by Thomas Keller, Nov 30, 2011

Tested and applied in revision 154597c. Thanks again!

Status: Fixed

Indefero