Indefero

Issue 660: Can't make a general comment on code review without a comment on a file

Reported by William Martin, Apr 2, 2011

We can't make a simple general comment.
The form tell "we need to comment at less one file".

I think is too restrictive.

loic, tommyd: Some idea ?

Comment 1 by Thomas Keller, Apr 2, 2011

Agreed, it should be possible to do general comments without 
per-file comments.

Comment 2 by William Martin, Apr 6, 2011

commit f88e529b8513bc4ae951a2c38848ce40159e3334
Status: Fixed

Comment 3 by Thomas Keller, Apr 6, 2011

Labels: Milestone:Release1.2

Comment 4 by Thomas Keller, Apr 6, 2011

Thanks for the fix, William!

Two small notices - please put a single space between the 
"if" keyword and the following condition and consider 
writing the NEWS.mdtext file further, i.e. by including the fix in 
the stanza of the particular release (for example, if you fix 
something in the release-1.1 branch, note the fix in the 1.1.2 
release notes) or tag the fix at least for either milestone (1.2 or 
1.1.2, again, depending on the branch where you checked it in), so I 
can find and add it to NEWS.mdtext later before we actually release 
the specific version.

Thanks!

Created: 2 years 2 months ago by William Martin

Updated: 2 years 2 months ago

Status: Fixed

Owner: William Martin

Followed by: 1 person

Labels:
Priority:Medium
Type:Enhancement
Milestone:Release1.2