Reported by Stewart, Mar 23, 2011
Having upgraded from v1.0 to release-1.1 (Database migration to latest Pluf master was successful) a single commit started causing 500 server errors in indefero. ---------------- PlufErrorHandlerException making GET request to /index.php/p/evony-core/source/commit/47a7cc31d36bb3144bc90a29581177c 18b9e487a/ 8 : Undefined index: LICENSE.rtf PHP: /tmp/Pluf_Template-0368b159f9509f776ce224afdb90a75b.phps, line 157 URI: GET /index.php/p/evony-core/source/commit/47a7cc31d36bb3144bc90a29581177c 18b9e487a/ ---------------- The full error is available in the attached EmailError.txt. Diff.txt shows the git diff for the two commits The only thing noteworthy about LICENSE.rtf is it is a binary file.
Comment 1 by Stewart, Mar 23, 2011
Comment 2 by Patrick Georgi, Mar 23, 2011
binary-diff-fix.diff should fix it. The issue is that binary files (or files considered as such by the SCM) are listed in a file list (at least for git) but don't appear in the diff (for obvious reasons). This change makes the diff view use the list of files present in the diff, instead of the more complete list of changed files
Summary: commit view doesn't handle commits with changes to binary files
Comment 3 by Thomas Keller, Mar 23, 2011
Comment 4 by Thomas Keller, Mar 25, 2011
@Patrick: Your proposed fix is not good. It effectivly skips the information that a binary file was changed at all in a certain commit and we certainly want to keep this information. What we actually want is skipping the link down to the diff section for a binary diff (because there simply is none). I did this in revision f131083.