Indefero

Issue 569: RFC: Enhanced VCS number linking

Reported by Thomas Keller, Nov 20, 2010

Attached is a patch which improves the way indefero recognizes 
possible source code commits. The current implementation forces the 
user to prefix his revision with "commit" or 
"commits" (in case there are several IDs listed).

The new code allows several verbs and nouns to be given, so 
"added in 123", "revisions abcde123 and r456", 
"changed in 123", "handled in rev 234", and 
several other permutations are recognized and properly linked.

What is not yet recognized as standalone marker is "r" - 
like in "r123". While it is ignored, i.e. parsed out in 
conjunction with a proper verb or noun, it is not recognized yet 
with any other not-predefined verb.

In the end this is all very fuzzy, there is probably no 100% 
solution, but this one catches a couple of possibilities more than 
the current one. I did not commit it right away because I'm looking 
for feedback for other possible useful nouns and verbs as well as 
your opinions on clashes or "false positives" with the new 
implementation.

Comment 1 by Thomas Keller, Nov 24, 2010

Owner: loic

Comment 2 by Thomas Keller, Nov 28, 2010

The patch has been improved to handle extended src: links as well:

* src:path@rev, src:path#line and src:path@rev#line are now 
supported
* bugfix: a comma or (unescaped) space ends the link parsing

Comment 3 by Loïc d'Anterroches, Nov 29, 2010

False positives will not be a problem in the sense that you as human 
will automatically detect them. You will directly figure out that 
the parser made a mistake.
Status: Accepted
Owner: tommyd

Comment 4 by Thomas Keller, Nov 29, 2010

checked in commit dc2881a - will update the wiki shortly
Status: Fixed

Comment 5 by Thomas Keller, Nov 30, 2010

Wiki has been updated.
Labels: Milestone:Release1.1

Created: 2 years 5 months ago by Thomas Keller

Updated: 2 years 5 months ago

Status: Fixed

Owner: Thomas Keller

Followed by: 1 person

Labels:
Priority:Medium
Type:Patch
Milestone:Release1.1