Issue 546: irc:// URIs are not recognized

Reported by Thomas Keller, Oct 7, 2010

IRC uris like irc://irc.oftc.net/tommyd,isnick are misinterpreted as 
www links. Markdown seems to make this correct (tried [IRC](
irc://irc.oftc.net/tommyd,isnick) with their dingus setup), but IDF 
converts them wrongly to local links (#<something>).

Comment 1 by Thomas Keller, Oct 7, 2010

Seems to be a problem in Pluf/Text/Markdown.php - I couldn't find a 
quick fix, though. The URI is properly "hashed", but I 
can't find the place where it is improperly "unhashed" 
again.

Comment 2 by Thomas Keller, Oct 26, 2010

Labels: Priority:Low ~~Priority:Medium~~

Comment 3 by Ludovic Bellière, Oct 29, 2010

Not an indefero bug. This file is part of PHP Markdown Extra created 
by Michel Fortin (http://daringfireball.net/projects/markdown/)

Please, report upstream to: michel.fortin@michelf.com

Please include with your report:
(1) the example input;
(2) the output you expected;
(3) the output Markdown actually produced.

Comment 4 by Thomas Keller, Oct 29, 2010

Hrm... I'm not quite sure - if I try the above example within 
Markdown's Dingus, it works:

  http://michelf.com/projects/php-markdown/dingus/

so does the original version:

  http://daringfireball.net/projects/markdown/dingus

This doesn't look like an upstream bug to me.

Comment 5 by Thomas Keller, Nov 24, 2010

Loic, you know the Pluf code here better - where is this bug hidden?

Owner: loic

Comment 6 by Loïc d'Anterroches, Nov 29, 2010

Right now, the comment in this page at the top is working for me. 
That is, it request to open my IRC client. So, it works for me. Do 
you have an example somewhere where it does not work?

Owner: tommyd

Comment 7 by Thomas Keller, Nov 29, 2010

Its not an issue here, but in the documentation section. Create a 
new page and add the following without spaces and extra newlines 
into the content, then hit preview:

"Test [IRC](irc://irc.oftc.net/tommyd,isnick) here"

This is converted to this HTML:

<p>Test <a 
href="#//irc.oftc.net/tommyd,isnick">IRC</a> 
here</p>

Owner: loic

Comment 8 by William Martin, Jan 4, 2011

Just add irc in the allow protocols list in the Markdown Prefilter ?

Like in this patch

0001-Issue-546-Add-git-and-irc-in-the-allow-protocol-list.patch - 1.07 kB - view

Comment 9 by Thomas Keller, Jan 4, 2011

Indeed this seems to be the right place - I wonder though why there 
is an restriction on allowed protocols to link to at all...?! To 
avoid javascript:-style links?

Comment 10 by William Martin, Jan 6, 2011

Fix in commit 4245617c6f2972ffb7a21723da809dc4c34113af

Labels: Milestone:Release1.1
Status: Fixed

Indefero