Reported by Thomas Keller, Sep 1, 2010
The attachment view for diff or patch files is quite ugly, since IDF_Diff::pad only replaces the leading whitespaces by 's, but not the inner ones, leading to improper indentation for added ('+') or removed ('-') lines or - of course - any kind of other file where more than one whitespace needs to be present. IMHO the above mentioned function should be completly replaced by browser CSS - because "white-space: pre" has actually the effect we want, without custom replacement at all. According to quirksmode ( http://www.quirksmode.org/css/whitespace.html) this CSS property is available in all major browsers, even IE6.
Comment 1 by Thomas Keller, Oct 9, 2010
Fixed in commit d994e0e. For now I only changed the CSS, so the view looks proper now, but the code which replaces the spaces (IDF_Diff::padLine) is still in there and should probably also removed some time.
Comment 2 by Thomas Keller, Nov 25, 2010