Reported by Matías Halles, Jul 19, 2010
Hi again :) I've been making work out the log parsing function in Mercurial and i think there is some issue that should be addressed before digging into the function itself. Mercurial can create an output when "hg log" is issued, based on templates. There is a default template, and two others the user can choose from. Also you can configure your mercurial install to use one of this as default on your [.]hgrc file. This last point could be an issue if the user in fact changes their default template to something other than the default template; this due to the fact that that parseLog function relies on this default template's parttern. So, since parseLog is not working correctly as far as i can tell (it's not parsing the full message and putting into the tables, and the regexp pattern in charge of parsing header is/was buggy) and the fact that the user could in fact change the template and break indefero mercurial integration, i think we should create a custom template and tweak it to indefero's needs making the parseLog function much easier to create and debug. The other solution is to force "--style default" whan calling hg log, but i still like the first solution better. I will indeed work in this for my own usage since i need it soon, but i would like to know if someone wants to give some input, ideas, maybe collab, etc. Regards, Matías.
Comment 1 by Matías Halles, Jul 24, 2010
So here's my patch.
Comment 2 by Matías Halles, Jul 24, 2010
So... here's the patch to the patch :p Changed var for protected in the class definition.
Comment 3 by Loïc d'Anterroches, Sep 6, 2010
Great. Marked to patch.
Comment 4 by Thomas Keller, Mar 18, 2011
Your patch has been applied in commit 5fc3a98. Many thanks!
Comment 5 by Thomas Keller, Mar 18, 2011