Reported by Romain Bertrand, Jun 22, 2010
This patch enables the mailing to all project members and admins when a task is created without an owner.
- patch_project_mailing - 1.25 kB
Comment 1 by Romain Bertrand, Jun 23, 2010
.patch is better
Comment 2 by Loïc d'Anterroches, Jun 23, 2010
I don't really know if this feature is good or not. But I agree to bet on it, that is, I accept it and we will see how users react on it. Please, update your patch to follow the PEAR coding standard with spaces only (no tabs): http://pear.php.net/manual/en/standards.php What you could do, is email all the project admins/owners also when updated without an owner, that would be consistent. The $to_email array is an array of array with the target language included (email, lang). This allows sending the email in the preferred language of the user. Thanks a lot for your contribution. If you need more help to get this done, please let me know.
Comment 3 by Romain Bertrand, Jul 6, 2010
Sorry for the delay, and sorry for eclipse fucking up the style of the patch, I used a properly configured vim this time. Please find attached an updated version of the patch.
Comment 4 by Thomas Keller, Oct 26, 2010
Comment 5 by Thomas Keller, Nov 24, 2010
Loic, please comment on the updated patch and eventually commit it. Thanks!
Comment 6 by Loïc d'Anterroches, Nov 29, 2010
Comment 7 by Thomas Keller, Mar 3, 2011
@Loic: Do you want to re-target this for 1.2 or apply for 1.1?
Comment 8 by Thomas Keller, Mar 8, 2011
Taking over and applying tonight
Comment 9 by Thomas Keller, Mar 8, 2011
Taking this over, will work on it tonight.
Comment 10 by Sylvestre Ledru, Mar 9, 2011
hello guys, What is the ETA of the version 1.1 ? This bug is very boring :/ thanks
Comment 11 by Thomas Keller, Mar 9, 2011
I thought about this a bit more and think we should make this behaviour configurable, especially if some kind of global issue notification is already set up. I think this is needed to not have people complain about doubled notifications or notification spam in general, especially if a team consists of many people and only a minority of them is actually interested in issue updates. So my plan is the following: 1) Add a new configuration option to the "Issue tracking" view in the "Project Management" section, something like "Notify [nobody, only owners, owners and members v] about new tickets and ticket updates that have no owner setting", where the thing in rectangular brackets is a dropdown list which defaults to "nobody" 2) change the attached patch so that it uses the correct subset of users (by default "nobody") to notify depending on this setting 3) (optionally) allow another "exclude the following people from notifications" textarea that lists members that should get no notification to whatever group they're counted (owners or members) Extra authorized users would not be notified at all. Since all this requires more changes, more testing and even some more i18n strings, I'm retargeting this for 1.2.
Comment 12 by Sylvestre Ledru, Aug 23, 2011
When emails are sent, it would be nice to have a feedback listing all the email address to which the alert as been sent (like with bugzilla)
Comment 13 by Thomas Keller, Oct 10, 2011
@Sylvestre: Right now we're sending individual emails, also because the user's language settings can be different and because the content of the individual email could be slightly different as well. If we want to include information who was also notified, then we cannot do this via the standard To: or CC: fields, but in some custom text section in the body. I'm not sure if this is then still wanted (e.g. a "reply-all" in the mail client would not work in this case). Anyways, I'm removing the 1.2 target for this, because we want to get 1.2 out on the street in a couple of weeks, and this is something that needs a bigger overhaul.
Comment 14 by Sindre Myren, Oct 10, 2011
@Thomas: This is only my oppinion, but I think as a project member, you should be able to handle a sertaint amount of "spam". I think it is much better to get an email to many (in this ONE particular case), then one to few - I once had an issue lying unresolved and uncommented in a InDefero installation for 6 months, before I relaised that you activly had to set a CC email to be notified on new issues! I guess I just assumed that project owners and members would be notified when new issues arrived! Not very pleas for the person who submitted the Issue... So I think you should apply the patch now, and (maybe) write the configuration bit later. Sometimes it's better to just keep things simple stupid, then to make everything configurable. Maybe justy make it configurtable on a per-forge basis - i.e. add it to the config file.
Comment 15 by Thomas Keller, Oct 10, 2011
Incidentially SciLab currently plans to sponsor some work for IDF where a rework of the notification functionality is included as one item. We're currently working out a couple of setup issues still, but once this is over, we'll have a fully configurable behaviour here.
Comment 16 by Loïc d'Anterroches, Oct 10, 2011
Happy to read that the SciLab work is going ahead! Congrats!
Comment 17 by Sylvestre Ledru, Oct 10, 2011
> @Sylvestre: Right now we're sending individual emails, > also because the user's language settings can be > different and because the content of the individual > email could be slightly different as well. => actually, I wasn't talking about the email itself but on the website once you submitted it. For example, with bugzilla, when you interact with a bug, you have a feedback: " Changes submitted for bug 10077 Email sent to: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Excluding: no one " PS: it is Scilab, not SciLab ;)
Comment 18 by Thomas Keller, Oct 10, 2011
Ah ok, but then I'd think this is a different feature. Its kind of a "notification about the notification". I'd also argue that this might not always be wanted, because it implies privacy issues (and even if we only show usernames and something like "send out notifications to Tom, Joe and 3 other email addresses" then this could still be a little of an issue). Anyways, please open a separate ticket for that feature if you want.
Comment 19 by Thomas Keller, Oct 10, 2011
s/send/sent/ and yes, sorry, Scilab, I think I'll learn it someday :)
Comment 20 by Thomas Keller, Nov 5, 2011
Fixed with revision 82a2d6a.