InDefero

Sign in or create your account | Project List | Help

Issue 268: Atom feed corrupt

Reported by Sebastian Hoß, Jul 17, 2009

Hi there,

i just noticed that the latest update page supplies an Atom news 
feed. That is really great but it seems to have a problem with the 
git commit messages which are signed-off. Those signed-off lines 
could contain an e-mail address which is not properly escaped. This 
prevents any newsreader from parsing the feeds correctly (Firefox 
displays nothing, Thunderbird refuses to parse, Opera seems to enter 
an infinite loop, Claws-Mail won't parse either, ...). I think the 
line:

  Signed-off-by: Sebastian Hoß <mail@shoss.de>

Should be escaped like:

  Signed-off-by: Sebastian Hoß &lt;mail@shoss.de&gt;

So "<" and ">" replaced with 
"&lt;" and "&gt;". 

After noticing that i ran the feed through the feedvalidator at 
beta.feedvalidator.org and it shows some more minor problems with 
the feed:
  - The main "feed" element is missing the 
"updated" element. This should be set to the time of the 
last update of the feed itself. As InDefero is already keeping track 
of update dates this should be rather simple to do?
  - Every "entry" element is missing the 
"author" element. This should be simple as well since 
InDefero shows us who did the update already.
  - It is possible for 2 (or more) entries to have the same ID. This 
shouldn't be possible since every entry should be unique. So with 
the current behavior some newsreaders may decide only to display the 
latest entry and skip all others. This problem happens when you edit 
the same documentation page 2 consecutively.
  - IDs for downloads are not full and valid URLs (they are 
relative).


Result for my projects feed is at: 
http://beta.feedvalidator.org/check.cgi?url=http%3A%2F%2Fdenove.indef
ero.net%2Fp%2Fcore%2Ffeed%2Ftimeline%2Ftoken%2F5cZm1j%2F

And the result for the InDefero feed is at: 
http://beta.feedvalidator.org/check.cgi?url=http%3A%2F%2Fprojects.ceo
ndo.com%2Fp%2Findefero%2Ffeed%2Ftimeline%2Ftoken%2FedamqbnWY%2F

Comment 1 by Loïc d'Anterroches, Jul 18, 2009

Great and detailed bug report, thanks a lot! I will take care of it.

Comment 2 by Sebastian Hoß, Jul 18, 2009

No deal :-) and sorry for the bad timing. If you need any help let 
me know..

Comment 3 by Loïc d'Anterroches, Aug 3, 2009

Just a note for me when taking care of this ticket. The code to 
generate the atom feed should be moved to a template and should not 
be in the source like it is now.

Comment 4 by Loïc d'Anterroches, Oct 8, 2009

Ok, I have a good work in progress on this one. I have reworked the 
commit part using a template and fixed the feed level errors. 

I will convert all the feed elements to use a template and push that 
into the repository. Again Sebastian, your bug report is great!
Status: Started
Owner: loic

Comment 5 by Loïc d'Anterroches, Oct 9, 2009

Fixed in commit f3cadfe, only the code review is left, but at the 
moment they are not in the timeline.
Status: Fixed

Created: 7 months 22 days ago by Sebastian Hoß

Updated: 5 months 2 days ago

Status: Fixed

Owner: Loïc d'Anterroches

Followed by: 1 person

Labels:
Type:Defect
Priority:Medium