Comment 1 by Loïc d'Anterroches, May 7, 2009
To be fixed in: src:src/IDF/Commit.php src:src/IDF/Issue.php src:src/IDF/IssueComment.php src:src/IDF/Upload.php src:src/IDF/WikiPage.php src:src/IDF/WikiRevision.php
Comment 2 by Loïc d'Anterroches, May 7, 2009
Fixed in commit 63cdede, thanks a lot for the good practice reminder about localisation. If you find other problematic points feel free to report them. Good localisation is for me critical.
Status: Fixed
Sign in to reply to this comment.
Reported by Patrick Georgi, Apr 22, 2009
Looking through the gettext files, I found various strings like "by" to translate. They're not very useful in themselves and might be hard to translate in certain languages. Instead of <div class="helptext right">'.__('Commit').' <a href="'.$url.'" class="mono">'.$this->scm_id.'</a>, '.__('by').' '.$user.'</div></td></tr>'; use '.sprintf(_("Commit %s by %s"),'<a href="'.$url.'" class="mono">',$user); A language that has to switch arguments would translate "Commit %s by %s" as "%2$s committed %1$s" (or something like that)