InDefero

Sign in or create your account | Project List | Help

Issue 205: Clean up some gettext strings

Reported by Patrick Georgi, Apr 22, 2009

Looking through the gettext files, I found various strings like 
"by" to translate. They're not very useful in themselves 
and might be hard to translate in certain languages.

Instead of

<div class="helptext 
right">'.__('Commit').'&nbsp;<a 
href="'.$url.'" 
class="mono">'.$this->scm_id.'</a>, 
'.__('by').' '.$user.'</div></td></tr>';

use

'.sprintf(_("Commit&nbsp;%s by %s"),'<a 
href="'.$url.'" class="mono">',$user);

A language that has to switch arguments would translate
"Commit&nbsp;%s by %s"
as
"%2$s committed %1$s" (or something like that)

Comment 2 by Loïc d'Anterroches, May 7, 2009

Fixed in commit 63cdede, thanks a lot for the good practice reminder 
about localisation. If you find other problematic points feel free 
to report them. Good localisation is for me critical.
Status: Fixed

Created: 10 months 26 days ago by Patrick Georgi

Updated: 10 months 14 days ago

Status: Fixed

Followed by: 1 person

Labels:
Type:Defect
Priority:Medium