InDefero

Sign in or create your account | Project List | Help

Issue 165: Multiple SSH keys per user

Reported by Ciaran Gultnieks, Mar 24, 2009

Multiple SSH keys per user should be allowed (as per gitosis and 
gitorious, for example).

It looks like the database is already structured to support this, so 
perhaps it is just a case of the additional web site UI?

Comment 1 by Loïc d'Anterroches, Mar 26, 2009

Yes, this is planned and already requested in issue 147 (in French 
so I understand you haven't found it).
Labels: Type:Enhancement, -Type:Defect

Comment 2 by Sindre Myren, Apr 13, 2009

Just want to add my support for this issue.

Comment 3 by Vedang Manerikar, Jun 25, 2009

Hi guys, 
joined indefero today and was immediately hindered by lack of 
multiple ssh keys. Can you give me an idea as to when this issue 
will be resolved?

Comment 4 by Loïc d'Anterroches, Jul 10, 2009

It should be possible to have deploy keys with read only rights.
Labels: Priority:High, -Priority:Medium

Comment 5 by Andrew Nguyen, Jul 14, 2009

Not sure where you are with this but I desperately needed this today 
and have coded up another patch.  

I decided to modify the schema a little and added a column for a 
short description of the key - otherwise I had no idea which key 
went where when considering to delete one.

It is attached in case you're interested in it.

Comment 6 by Andrew Nguyen, Jul 14, 2009

Forgot to add new files in the above patch

Comment 7 by Loïc d'Anterroches, Jul 14, 2009

This is great Andrew, I will check that as soon as possible!

Comment 8 by Loïc d'Anterroches, Jul 14, 2009

Andrew, in your delete key view, you are not checking that the key 
belongs to the user doing the request. Any signed in user can drop 
any key.

Comment 9 by Andrew Nguyen, Jul 14, 2009

Good to know - I assumed (without looking into it at all) that the 
loginRequired precondition verified that implicitly.

I will fix that.

Comment 10 by Andrew Nguyen, Jul 14, 2009

Not sure if this is good enough or the proper way.  I must say Pluf 
seems pretty easy to work with - since I have no prior PHP 
experience.

Comment 11 by Loïc d'Anterroches, Jul 15, 2009

This is good. You can even replace:

$request->user->setMessage(__('Attempting to delete key owned 
by another user'));

with:

return new Pluf_HTTP_Response_Forbidden($request);

The loginRequired precondition is only checking that the user is 
effectively signed in and is not anonymous.

Thanks a lot for the nice comments about Pluf, you are making my day.

Comment 12 by Andrew Nguyen, Jul 15, 2009

Would you like me to make this change and resubmit a patch?

Comment 13 by Tim Wang, Aug 30, 2009

just show my support for this feature. When will you implement this 
to the hosted edition?

Comment 14 by Robbie Trencheny, Dec 18, 2009

any update on this? the patch no longer works :(

Comment 15 by Denis Kot, Dec 23, 2009

my vote for this!

Comment 16 by Loïc d'Anterroches, Feb 14, 2010

Labels: Milestone:Release1.0

Comment 17 by Loïc d'Anterroches, Feb 22, 2010

Added in commit cc6f1c7, enjoy!
Status: Fixed

Created: 1 year 5 months ago by Ciaran Gultnieks

Updated: 6 months 11 days ago

Status: Fixed

Followed by: 9 persons

Labels:
Priority:High
Type:Enhancement
Milestone:Release1.0